[
https://issues.apache.org/jira/browse/LUCENE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733753#action_12733753
]
Yonik Seeley commented on LUCENE-1754:
--------------------------------------
bq. So if we agree that scorer() cannot return null, I think that most of the
patch can be reverted, and I'll change the scorer() impls which return null to
return NMS instead?
I haven't looked deeply into it, but at first blush that could simplify client
code.
Need to watch out if there are any implementations of Weight.explain() that
cast to a Specific type of scorer - hence one would get a cast exception if
"return null" were blindly replaced with "return NMS".
> Get rid of NonMatchingScorer from BooleanScorer2
> ------------------------------------------------
>
> Key: LUCENE-1754
> URL: https://issues.apache.org/jira/browse/LUCENE-1754
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Shai Erera
> Assignee: Michael McCandless
> Priority: Minor
> Fix For: 2.9
>
> Attachments: LUCENE-1754.patch
>
>
> Over in LUCENE-1614 Mike has made a comment about removing NonMatchinScorer
> from BS2, and return null in BooleanWeight.scorer(). I've checked and this
> can be easily done, so I'm going to post a patch shortly. For reference:
> https://issues.apache.org/jira/browse/LUCENE-1614?focusedCommentId=12715064&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12715064.
> I've marked the issue as 2.9 just because it's small, and kind of related to
> all the search enhancements done for 2.9.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
