[ 
https://issues.apache.org/jira/browse/LUCENE-1460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734784#action_12734784
 ] 

Uwe Schindler commented on LUCENE-1460:
---------------------------------------

no, make them final. the same happened with asciifoldingfilter, was never 
released, so can be changed.

In general, all tokenstreams should be final or have final impls (see 
LUCENE-1753 for explanation). The only real example of a non-final one is 
CharTokenizer, which is abstract but the tokenization impls are final :)

> Change all contrib TokenStreams/Filters to use the new TokenStream API
> ----------------------------------------------------------------------
>
>                 Key: LUCENE-1460
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1460
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Michael Busch
>            Assignee: Michael Busch
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1460_contrib_partial.txt, LUCENE-1460_core.txt, 
> LUCENE-1460_partial.txt
>
>
> Now that we have the new TokenStream API (LUCENE-1422) we should change all 
> contrib modules to use it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to