[
https://issues.apache.org/jira/browse/LUCENE-1762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1762:
----------------------------------
Attachment: LUCENE-1762.patch
Slightly modified patch (some small refactoring). I also fixed a bug in Token,
because the Payload was not deep cloned in copyTo(), which is done by the
simple attributes and needed for restoring the state in AttributeSource. Also
added tests for this.
I think it is ready for commit. I will do this in a day or two.
> Slightly more readable code in TermAttributeImpl
> -------------------------------------------------
>
> Key: LUCENE-1762
> URL: https://issues.apache.org/jira/browse/LUCENE-1762
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Analysis
> Affects Versions: 2.9
> Reporter: Eks Dev
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 2.9
>
> Attachments: LUCENE-1762-bw.patch, LUCENE-1762.patch,
> LUCENE-1762.patch, LUCENE-1762.patch, LUCENE-1762.patch, LUCENE-1762.patch
>
>
> No big deal.
> growTermBuffer(int newSize) was using correct, but slightly hard to follow
> code.
> the method was returning null as a hint that the current termBuffer has
> enough space to the upstream code or reallocated buffer.
> this patch simplifies logic making this method to only reallocate buffer,
> nothing more.
> It reduces number of if(null) checks in a few methods and reduces amount of
> code.
> all tests pass.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
