[
https://issues.apache.org/jira/browse/LUCENE-1504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737498#action_12737498
]
Uwe Schindler edited comment on LUCENE-1504 at 7/31/09 4:27 AM:
----------------------------------------------------------------
So you mean we should simply kick this new class and use whats already in
Lucene? I would like this.
I think the idea behind Ryans patch was, to create a Filter using a BitSet and
do the chaining directly on *one* instance of the BitSet. In my opinion, this
is not, what the new DocIdSet should do. The Filter chaining should be done in
the iterator.
Another approach would be to use the BooleanFilter from contrib/search! It has
all the functionality provided by Ryans class. We would only need to have build
dependency between contrib/spatial and contrib/queries.
was (Author: thetaphi):
So you mean we should simply kick this new class and use whats already in
Lucene? I would like this.
I think the idea behind Ryans patch was, to create a Filter using a BitSet and
do the chaining directly on *one* instance of the BitSet. In my opinion, this
is not, what the new DocIdSet should do. The Filter chaining should be done in
the iterator.
> SerialChainFilter should use DocSet API rather then deprecated BitSet API
> -------------------------------------------------------------------------
>
> Key: LUCENE-1504
> URL: https://issues.apache.org/jira/browse/LUCENE-1504
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Reporter: Ryan McKinley
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1504.patch, LUCENE-1504.patch
>
>
> From erik's comments in LUCENE-1387
> * Maybe the Filter's should be using the DocIdSet API rather than the
> BitSet deprecated stuff? We can refactor that after being committed I
> supposed, but not something we want to leave like that.
> We should also look at moving SerialChainFilter out of the spatial contrib
> since it is more generally useful then just spatial search.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
