[
https://issues.apache.org/jira/browse/LUCENE-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740667#action_12740667
]
Michael McCandless commented on LUCENE-1771:
--------------------------------------------
Patch looks good!:
* Looks like you need to "svn rm
src/java/org/apache/lucene/search/QueryWeight.java"
* Some javadocs still reference QueryWeight
* Why do we need this in Weight?
{code}
public Explanation explain(IndexReader reader, int doc) throws IOException {
return explain(null, reader, doc);
}
{code}
Ie, do we think there are places outside of Lucene that invoke
Weight.explain directly?
> Using explain may double ram reqs for fieldcaches when using
> ValueSourceQuery/CustomScoreQuery or for ConstantScoreQuerys that use a
> caching Filter.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-1771
> URL: https://issues.apache.org/jira/browse/LUCENE-1771
> Project: Lucene - Java
> Issue Type: Bug
> Components: Search
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 2.9
>
> Attachments: LUCENE-1771.bc-tests.patch, LUCENE-1771.patch,
> LUCENE-1771.patch, LUCENE-1771.patch, LUCENE-1771.patch, LUCENE-1771.patch,
> LUCENE-1771.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
