Or, we can just throw that detection out of the window, for less smooth back-compat experience, less hacky code and no slowdown.
On Mon, Aug 10, 2009 at 19:02, Uwe Schindler<u...@thetaphi.de> wrote: > The question is, if that would get better if the reflection calls are only > done one time per class using a IdentityHashMap<Class,Boolean>. The other > reflection code in AttributeSource uses a static cache for such type of > things (e.g. the Attribute -> AttributeImpl mappings in AttributeSource. > DefaultAttributeFactory.getClassForInterface()). > > I could do some tests about that and supply a patch. I was thinking about > that but throwed it away (as it needs some synchronization on the cache Map > which may also overweigh). > > ----- > Uwe Schindler > H.-H.-Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: u...@thetaphi.de > >> -----Original Message----- >> From: Mark Miller [mailto:markrmil...@gmail.com] >> Sent: Monday, August 10, 2009 4:48 PM >> To: java-dev@lucene.apache.org >> Subject: Re: indexing_slowdown_with_latest_lucene_udpate >> >> Robert Muir wrote: >> > This is real and not just for very short docs. >> Yes, you still pay the cost for longer docs, but it just becomes less >> important the longer the docs, as it plays a smaller role. Load a ton of >> one term docs, and it might be 50-60% slower - add a bunch of articles, >> and it might be closer to 20%-15% (I don't know the numbers, but the >> longer I made the docs, the less % slowdown, obviously). Still a good hit, >> but a short doc test magnafies the problem. >> >> It affects things no matter what, but when you don't do much tokenizing, >> normalizing, the cost of the reflection/tokenstream init dominates. >> >> - Mark >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: java-dev-h...@lucene.apache.org > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-dev-h...@lucene.apache.org > > -- Kirill Zakharenko/Кирилл Захаренко (ear...@gmail.com) Home / Mobile: +7 (495) 683-567-4 / +7 (903) 5-888-423 ICQ: 104465785 --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
