[ 
https://issues.apache.org/jira/browse/LUCENE-1847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12746968#action_12746968
 ] 

Michael McCandless commented on LUCENE-1847:
--------------------------------------------

Looks good!

Your isMethodOverridden is incorrectly checking against
TokenStream.class (should be Similarity.class instead).  Maybe add a
test case that asserts "maxDocs=XXX" is present in TermQuery's explain?

Small typo: explaination -> explanation


> PhraseQuery/TermQuery/SpanQuery use IndexReader specific stats in their 
> explains
> --------------------------------------------------------------------------------
>
>                 Key: LUCENE-1847
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1847
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Mark Miller
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 2.9
>
>         Attachments: LUCENE-1847.patch, LUCENE-1847.patch
>
>
> PhraseQuery uses IndexReader in explainfor top level stats - as mentioned by 
> Mike McCandless in LUCENE-1837.
> TermQuery uses IndexReader in explain for top level stats
> Always been a bug with MultiSearcher, but per segment search makes it worse.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to