[ 
https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747191#action_12747191
 ] 

Luis Alves commented on LUCENE-1852:
------------------------------------

I reviewed the code, all changes look good to me.

I tested it and it looks good :).

Michael can you commit this patch with LUCENE-1836, both are related and this 
issue prereqs it.

> Fix remaining localization test failures in lucene
> --------------------------------------------------
>
>                 Key: LUCENE-1852
>                 URL: https://issues.apache.org/jira/browse/LUCENE-1852
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Luis Alves
>             Fix For: 2.9
>
>         Attachments: LUCENE-1852.patch
>
>
> see also LUCENE-1836 and LUCENE-1846
> all tests should pass under different locales.
> the fix is to run 'ant test' under different locales, look and fix problems, 
> and use the LocalizedTestCase from LUCENE-1836 to keep them from coming back.
> the same approach as LUCENE-1836 fixes the core queryparser, but I am running 
> ant test under a few locales to look for more problems.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org


Reply via email to