[
https://issues.apache.org/jira/browse/LUCENE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12749303#action_12749303
]
Mark Miller edited comment on LUCENE-1877 at 8/30/09 11:53 AM:
---------------------------------------------------------------
My initial thought was also that it didn't really belong in IndexWriter - but I
sold myself on the fact that IndexWriter talks about locking and offers the
force unlock method - so it seems fine to me to mention how to use the optimal
locking factory (and generally avoid using the force unlock at all - as an
aside I just saw a guy trying to use that the other day as regular code so that
they could use two IndexWriters with just commit rather than close - ugg).
I'm not sold either way though - I'd go with whatever. My preference would
really be to make it the default (though of course not for 2.9).
was (Author: [email protected]):
My initial thought was also that it didn't really belong in IndexWriter -
but I sold myself on the fact that IndexWriter talks about locking and offers
the force unlock method - so it seems fine to me to mention how to use the
optimal locking factory (and generally avoid using the force unlock at all - as
an aside I just saw a guy trying to use that the other day as regular code so
that they could use two IndexWriters with just commit rather than close - ugg).
I'm not sold either way though - I'd go with whatever. My preference would
really be to make it the default.
> Improve IndexWriter javadoc on locking
> --------------------------------------
>
> Key: LUCENE-1877
> URL: https://issues.apache.org/jira/browse/LUCENE-1877
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Javadocs
> Reporter: Mark Miller
> Priority: Trivial
> Fix For: 2.9
>
>
> A user requested we add a note in IndexWriter alerting the availability of
> NativeFSLockFactory (allowing you to avoid retaining locks on abnormal jvm
> exit). Seems reasonable to me - we want users to be able to easily stumble
> upon this class. The below code looks like a good spot to add a note - could
> also improve whats there a bit - opening an IndexWriter does not necessarily
> create a lock file - that would depend on the LockFactory used.
> {code} <p>Opening an <code>IndexWriter</code> creates a lock file for the
> directory in use. Trying to open
> another <code>IndexWriter</code> on the same directory will lead to a
> {...@link LockObtainFailedException}. The {...@link
> LockObtainFailedException}
> is also thrown if an IndexReader on the same directory is used to delete
> documents
> from the index.</p>{code}
> Anyone remember why NativeFSLockFactory is not the default over
> SimpleFSLockFactory?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
