[
https://issues.apache.org/jira/browse/LUCENE-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750664#action_12750664
]
Uwe Schindler commented on LUCENE-1877:
---------------------------------------
Yes, I already prepared the BW test change (i simply disabled this test with
the lock prefix).
{quote}
bq. all FS-based lock factories use the same prefix encoding. They are now
(mostly) compatible. E.g. a lock obtained with NativeFSLockFactory would also
be seen as locked with SimpleFSLockFactory
Ie, it's unsupported to mix different LockFactory impls.
{quote}
One important fact, because I enabled this: The deprecated methods in
IndexWriter/IndexReader taking String/File args and FSDirectory.getDirectory()
still use the SimpleFSLockFactory per default (or the system property). If some
use mixes these deprecated calls with e.g. FSDir.open() he has still a chance
to get locking work. But it is unsupported. I also added a extra note in the
CHANGES.txt now, that warns because of this trap.
> Use NativeFSLockFactory as default for new API (direct ctors & FSDir.open)
> --------------------------------------------------------------------------
>
> Key: LUCENE-1877
> URL: https://issues.apache.org/jira/browse/LUCENE-1877
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Javadocs
> Reporter: Mark Miller
> Assignee: Uwe Schindler
> Fix For: 2.9
>
> Attachments: LUCENE-1877.patch, LUCENE-1877.patch, LUCENE-1877.patch
>
>
> A user requested we add a note in IndexWriter alerting the availability of
> NativeFSLockFactory (allowing you to avoid retaining locks on abnormal jvm
> exit). Seems reasonable to me - we want users to be able to easily stumble
> upon this class. The below code looks like a good spot to add a note - could
> also improve whats there a bit - opening an IndexWriter does not necessarily
> create a lock file - that would depend on the LockFactory used.
> {code} <p>Opening an <code>IndexWriter</code> creates a lock file for the
> directory in use. Trying to open
> another <code>IndexWriter</code> on the same directory will lead to a
> {...@link LockObtainFailedException}. The {...@link
> LockObtainFailedException}
> is also thrown if an IndexReader on the same directory is used to delete
> documents
> from the index.</p>{code}
> Anyone remember why NativeFSLockFactory is not the default over
> SimpleFSLockFactory?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
