+1 - I think thats great. I'm going to build RC3 and put it up after this is resolved in case anyone wants to bring something up first.
- Mark Uwe Schindler wrote: > How about that patch, this was my idea yesterday, but I didn't want to start > a new changes.txt format addition like this additional sentence in the > entry? > > ----- > Uwe Schindler > H.-H.-Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: [email protected] > > >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] On Behalf Of Yonik >> Seeley >> Sent: Wednesday, September 09, 2009 5:31 PM >> To: [email protected] >> Subject: Re: svn commit: r812983 - /lucene/java/trunk/CHANGES.txt >> >> On Wed, Sep 9, 2009 at 11:24 AM, Uwe Schindler<[email protected]> wrote: >> >>> Yes, but we discussed yesterday, that the involved persons developing >>> >> the >> >>> patches should get some credit... This is why I added this change to the >>> log. >>> >> If it's for the purpose of credit only, CHANGES should state that it's >> not an actual bug. >> Seems like there should be a threshold (i.e. non-trivial) for a new >> CHANGES entry for the purposes of credit only... people have to read >> this :-) If it's a significant contribution, simply add the person to >> the main CHANGES entry. >> >> Think about it this way... what would have been done if the >> bug/improvement was pointed out *before* the main feature had been >> committed? If the contribution happens after commit, treat it the >> same. >> >> -Yonik >> http://www.lucidimagination.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> > > > ------------------------------------------------------------------------ > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
