[
https://issues.apache.org/jira/browse/LUCENE-486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12758677#action_12758677
]
Michael Busch commented on LUCENE-486:
--------------------------------------
I still think we should remove the dependency that test has on demo. Looking
into the code you can replace the call of FileDocument in TestDoc with just 2
lines:
{code}
Document doc = new Document();
doc.add(new Field("contents", new FileReader(file)));
{code}
With this change alone we could remove the dependency. I think we should do
that because it makes the build cleaner and I don't think we'll pay less
attention to the demo code in the future just because we remove this classpath
dependency. Any objections? Otherwise I'll reopen this issue and attach a patch.
> Core Test should not have dependencies on the Demo code
> -------------------------------------------------------
>
> Key: LUCENE-486
> URL: https://issues.apache.org/jira/browse/LUCENE-486
> Project: Lucene - Java
> Issue Type: Test
> Affects Versions: 1.4
> Reporter: Grant Ingersoll
> Priority: Minor
> Attachments: FileDocument.java, testdoc.patch
>
>
> The TestDoc.java Test file has a dependency on the Demo FileDocument code.
> Some of us don't keep the Demo code around after downloading, so this breaks
> the build.
> Patch will be along shortly
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
