I think this code is correct? The null is forwarded so SegmentReader returns AllDocsEnum.
Mike On Sat, Oct 17, 2009 at 1:09 PM, John Wang <john.w...@gmail.com> wrote: > In DirectoryReader$MultiTermDocs implementation: > in method: protected TermDocs termDocs(IndexReader reader) > return term==null ? reader.termDocs(null) : reader.termDocs(); > Is this correct? > Shouldn't it be: > return term==null ? reader.termDocs() : reader.termDocs(term); > > Thanks > -John > > On Sat, Oct 17, 2009 at 8:11 AM, Yonik Seeley <yo...@lucidimagination.com> > wrote: >> >> On Wed, Oct 14, 2009 at 5:39 PM, Michael McCandless >> <luc...@mikemccandless.com> wrote: >> > I can cut the 2.9.1 release, but... should we wait a bit to see >> > whether other issues come up? >> >> I took a quick peek at the test code provided by Peter... and this >> certainly looks like a bug: >> https://issues.apache.org/jira/browse/LUCENE-1986 >> >> I'm heads down on the Solr release right now though, so I haven't had >> time to dig in. >> >> -Yonik >> http://www.lucidimagination.com >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: java-dev-h...@lucene.apache.org >> > > --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org