[
https://issues.apache.org/jira/browse/LUCENE-1987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-1987:
----------------------------------
Attachment: LUCENE-1987-StopFilter.patch
Hallo Mike,
attached is a patch with all deprecated methods removed (only the
setOverridesTokenStream is still there, making Analyzers final is another thing
to do).
Also StopFilter and its stopWord ets were generified (to <?>, which is ok for
every type of set, as CharArraySet uses toString() to convert everything to
string when testing, so any set is fine)
I only had the following problems and solution is here (StandardAnalyzer):
{code}
enableStopPositionIncrements = matchVersion.onOrAfter(Version.LUCENE_29);
replaceInvalidAcronym = matchVersion.onOrAfter(Version.LUCENE_23);
{code}
The setting defaultPosIncr was removed (static method, so there is no default
anymore). Because of that, the pre 2.9 default was false (which is now not
changeable). So I set the posIncr to false for all older versions (this was the
default before, but is now fixed as no static setter/sysprop anymore)
For the invalid acronyms I added LUCENE_23 version constant, so for all
versions >=2.3 it is enabled. If you want old behaviour, use LUCENE_22 or below.
Mike: Can you review this?
If you're ok with it I have to change 175 "new StandardAnalyzer()" occurences
in tests :(
> Remove rest of analysis deprecations (Token, CharacterCache)
> ------------------------------------------------------------
>
> Key: LUCENE-1987
> URL: https://issues.apache.org/jira/browse/LUCENE-1987
> Project: Lucene - Java
> Issue Type: Task
> Components: Analysis
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.0
>
> Attachments: LUCENE-1987-StopFilter.patch, LUCENE-1987.patch,
> LUCENE-1987.patch, LUCENE-1987.patch
>
>
> These removes the rest of the deprecations in the analysis package:
> - -Token's termText field-- (DONE)
> - -eventually un-deprecate ctors of Token taking Strings (they are still
> useful) -> if yes remove deprec in 2.9.1- (DONE)
> - -remove CharacterCache and use Character.valueOf() from Java5- (DONE)
> - Stopwords lists
> - Remove the backwards settings from analyzers (acronym, posIncr,...). They
> are deprecated, but we still have the VERSION constants. Do not know, how to
> proceed. Keep the settings alive for index compatibility? Or remove it
> together with the version constants (which were undeprecated).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
