[ 
https://issues.apache.org/jira/browse/LUCENE-2012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771428#action_12771428
 ] 

Uwe Schindler commented on LUCENE-2012:
---------------------------------------

No problem :) But then it should also have stopped at generics :-]

> Add @Override annotations
> -------------------------
>
>                 Key: LUCENE-2012
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2012
>             Project: Lucene - Java
>          Issue Type: Task
>            Reporter: Uwe Schindler
>             Fix For: 3.0
>
>         Attachments: LUCENE-2012.patch
>
>
> During removal of deprecated APIs, mostly the problem was, to not only remove 
> the method in the (abstract) base class (e.g. Scorer.explain()), but also 
> remove it in sub classes that override it. You can easily forget that 
> (especially, if the method was not marked deprecated in the subclass). By 
> adding @Override annotations everywhere in Lucene, such removals are simple, 
> because the compiler throws out an error message in all subclasses which then 
> no longer override the method.
> Also it helps preventing the well-known traps like overriding hashcode() 
> instead of hashCode().
> The patch was generated automatically, and is rather large. Should I apply 
> it, or would it break too many patches (but I think, trunk has changed so 
> much, that this is only a minimum of additional work to merge)?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to