[ 
https://issues.apache.org/jira/browse/LUCENE-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771546#action_12771546
 ] 

Robert Muir commented on LUCENE-2015:
-------------------------------------

Cédrik,

I think adding the idea of adding a public static method for folding is OK. but 
I think it should essentially do what foldToAscii does, not operate on a single 
'char'.

we should avoid single 'char' as parameter arguments, instead it should work on 
the entire char[] I think ?

> ASCIIFoldingFilter: expose folding logic + small improvements to 
> ISOLatin1AccentFilter
> --------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2015
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2015
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Analysis
>            Reporter: Cédrik LIME
>            Priority: Minor
>         Attachments: ASCIIFoldingFilter-no_formatting.patch, Filters.patch, 
> ISOLatin1AccentFilter.patch
>
>
> This patch adds a couple of non-ascii chars to ISOLatin1AccentFilter (namely: 
> left & right single quotation marks, en dash, em dash) which we very 
> frequently encounter in our projects. I know that this class is now 
> deprecated; this improvement is for legacy code that hasn't migrated yet.
> It also enables easy access to the ascii folding technique use in 
> ASCIIFoldingFilter for potential re-use in non-Lucene-related code.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to