CachingSpanFilter synchronizing on a none final protected object
----------------------------------------------------------------
Key: LUCENE-2030
URL: https://issues.apache.org/jira/browse/LUCENE-2030
Project: Lucene - Java
Issue Type: Improvement
Components: Search
Affects Versions: 2.9
Reporter: Simon Willnauer
Priority: Minor
Fix For: 3.1
Attachments: LUCENE-2030.patch
CachingSpanFilter and CachingWrapperFilter expose their internal cache via a
protected member which is lazily instantiated in the getDocSetId method. The
current code yields the chance to double instantiate the cache and internally
synchronizes on a protected none final member. My first guess is that this
member was exposed for testing purposes so it should rather be changed to
package private.
This patch breaks backwards compat while I guess the cleanup is kind of worth
breaking it.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
