I generified the searches/function files in patch 2037. I don't really think there's a conflict, just commit my patch and have at generifying the rest.
I know, I know. I did two things at once. So sue me. Honest, I'll try not to do this very often <G>... Mike: You really want to to the generify the whole shootin' match or do you want to partition them? I'll be happy to take a set of them. Or would that make things too complicated to apply? Erick On Thu, Dec 3, 2009 at 3:15 PM, Michael McCandless (JIRA) <j...@apache.org>wrote: > > [ > https://issues.apache.org/jira/browse/LUCENE-2037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785479#action_12785479] > > Michael McCandless commented on LUCENE-2037: > -------------------------------------------- > > bq. but there is another patch - LUCENE-2065 to port the existing tests to > Java 5 generics > > Ahh thanks for the reminder -- I can take this one as well, but, there will > be conflicts b/w the two patches, I think. Should we do the generics first > (simpler change, but touches many files), and then the junit4 upgrade? > > > Allow Junit4 tests in our environment. > > -------------------------------------- > > > > Key: LUCENE-2037 > > URL: https://issues.apache.org/jira/browse/LUCENE-2037 > > Project: Lucene - Java > > Issue Type: Improvement > > Components: Other > > Affects Versions: 3.1 > > Environment: Development > > Reporter: Erick Erickson > > Assignee: Michael McCandless > > Priority: Minor > > Fix For: 3.1 > > > > Attachments: junit-4.7.jar, LUCENE-2037.patch, LUCENE-2037.patch > > > > Original Estimate: 8h > > Remaining Estimate: 8h > > > > Now that we're dropping Java 1.4 compatibility for 3.0, we can > incorporate Junit4 in testing. Junit3 and junit4 tests can coexist, so no > tests should have to be rewritten. We should start this for the 3.1 release > so we can get a clean 3.0 out smoothly. > > It's probably worthwhile to convert a small set of tests as an exemplar. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-dev-h...@lucene.apache.org > >
