[ 
https://issues.apache.org/jira/browse/LUCENE-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788169#action_12788169
 ] 

Simon Willnauer commented on LUCENE-2139:
-----------------------------------------

Chris, I have a couple of issues with your patch. It seems that you renamed a 
couple of files which doesn't work well with patches for some reason. I will 
comment on this later again.
The other thing is that you use 1.6 classes like 
[http://java.sun.com/javase/6/docs/api/java/util/concurrent/LinkedBlockingDeque.html|LinkedBlockingDeque]
 but we should try to keep the contrib 1.5 dependent.
could you fix those 1.6 references please.

simon

> Cleanup and Improvement of Spatial Contrib
> ------------------------------------------
>
>                 Key: LUCENE-2139
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2139
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/spatial
>    Affects Versions: 3.1
>            Reporter: Chris Male
>            Assignee: Simon Willnauer
>         Attachments: LUCENE-2139.patch
>
>
> The current spatial contrib can be improved by adding documentation, tests, 
> removing unused classes and code, repackaging the classes and improving the 
> performance of the distance filtering.  The latter will incorporate the 
> multi-threaded functionality introduced in LUCENE-1732.  
> Other improvements involve adding better support for different distance 
> units, different distance calculators and different data formats (whether it 
> be lat/long fields, geohashes, or something else in the future).
> Patch to be added soon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org

Reply via email to