[
https://issues.apache.org/jira/browse/LUCENE-2147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated LUCENE-2147:
------------------------------------
Attachment: LUCENE-2147.patch
Chris, good stuff so far.
I have added a couple of final keywords and prevent some autoboxing in
GeoHashUtils as the char / int values should be mainly cached anyway. this
prevents a couple of object creations.
I also added a testcase which relates to the weird precision issues in
LUCENE-1815 that seem to be gone now - good stuff! -> btw I like that we have
only one decode method instead of the precision one.
At the current state I found that the SpatialConstants should be part of
DistanceUnits provided as getters. This might change in the future if there are
more constants but for now I would rather put them into the enum as this
enforces consistency for distance units.
thoughts?
> Improve Spatial Utility like classes
> ------------------------------------
>
> Key: LUCENE-2147
> URL: https://issues.apache.org/jira/browse/LUCENE-2147
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/spatial
> Affects Versions: 3.1
> Reporter: Chris Male
> Assignee: Simon Willnauer
> Attachments: LUCENE-2147.patch, LUCENE-2147.patch
>
>
> - DistanceUnits can be improved by giving functionality to the enum, such as
> being able to convert between different units, and adding tests.
> - GeoHashUtils can be improved through some code tidying, documentation, and
> tests.
> - SpatialConstants allows us to move all constants, such as the radii and
> circumferences of Earth, to a single consistent location that we can then use
> throughout the contrib. This also allows us to improve the transparency of
> calculations done in the contrib, as users of the contrib can easily see the
> values being used. Currently this issues does not migrate classes to use
> these constants, that will happen in issues related to the appropriate
> classes.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
