[
https://issues.apache.org/jira/browse/LUCENE-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12794762#action_12794762
]
Steven Rowe commented on LUCENE-2084:
-------------------------------------
Hi Robert, I took a look at the patch and found a couple of minor issues:
# The newly deprecated methods should get @Deprecated annotations (in addition
to the @deprecated javadoc tags)
# IntelliJ tells me that the "final" modifier on some of the public static
methods is not cool - AFAICT, although static implies final, it may be useful
to leave this anyway, since unlike the static modifier, the final modifier
disallows hiding of the method by sublasses? I dunno. (Checking Lucene
source, there are many "static final" methods, so maybe I should tell IntelliJ
it's not a problem.)
# Unlike getEncodedLength(byte[],int,int), getDecodedLength(char[],int,int)
doesn't protect against overflow in the int multiplication by casting to long.
> remove Byte/CharBuffer wrapping for collation key generation
> ------------------------------------------------------------
>
> Key: LUCENE-2084
> URL: https://issues.apache.org/jira/browse/LUCENE-2084
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/*
> Reporter: Robert Muir
> Assignee: Robert Muir
> Priority: Minor
> Fix For: 3.1
>
> Attachments: collation.benchmark.tar.bz2, LUCENE-2084.patch,
> LUCENE-2084.patch, LUCENE-2084.patch, LUCENE-2084.patch, LUCENE-2084.patch,
> TopTFWikipediaWords.tar.bz2
>
>
> We can remove the overhead of ByteBuffer and CharBuffer wrapping in
> CollationKeyFilter and ICUCollationKeyFilter.
> this patch moves the logic in IndexableBinaryStringTools into char[],int,int
> and byte[],int,int based methods, with the previous Byte/CharBuffer methods
> delegating to these.
> Previously, the Byte/CharBuffer methods required a backing array anyway.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
