[
https://issues.apache.org/jira/browse/LUCENE-2197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797952#action_12797952
]
Simon Willnauer commented on LUCENE-2197:
-----------------------------------------
bq. Here's a patch that reverts to the previous behavior of using the set
provided.
Doesn't seem to lead anywhere to discuss with the performance police when I
look at the average size of your comments. :)
This was actually meant to be a "pattern" for analyzer subclasses so I won't be
the "immutability" police here. Yonik, will you take this issue and commit?!
bq. We should really avoid this type of nannyism in Lucene.
oh well this seems to me like a void * is / isn't evil discussion - nevermind.
> StopFilter should not create a new CharArraySet if the given set is already
> an instance of CharArraySet
> -------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2197
> URL: https://issues.apache.org/jira/browse/LUCENE-2197
> Project: Lucene - Java
> Issue Type: Bug
> Components: Analysis
> Affects Versions: 3.1
> Reporter: Simon Willnauer
> Priority: Critical
> Fix For: 3.1
>
> Attachments: LUCENE-2197.patch, LUCENE-2197.patch
>
>
> With LUCENE-2094 a new CharArraySet is created no matter what type of set is
> passed to StopFilter. This does not behave as documented and could introduce
> serious performance problems. Yet, according to the javadoc, the instance of
> CharArraySet should be passed to CharArraySet.copy (which is very fast for
> CharArraySet instances) instead of "copied" via "new CharArraySet()"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
