[ https://issues.apache.org/jira/browse/LUCENE-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12798589#action_12798589 ]
Steven Rowe commented on LUCENE-2181: ------------------------------------- I think NewCollationAnalyzerTask should be a little more careful about parsing its parameters - here's a slightly modified version of your setParams() that understands "impl:jdk" and complains about unrecognized params: {code:java} @Override public void setParams(String params) { super.setParams(params); StringTokenizer st = new StringTokenizer(params, ","); while (st.hasMoreTokens()) { String param = st.nextToken(); StringTokenizer expr = new StringTokenizer(param, ":"); String key = expr.nextToken(); String value = expr.nextToken(); // for now we only support the "impl" parameter. // TODO: add strength, decomposition, etc if (key.equals("impl")) { if (value.equalsIgnoreCase("icu")) impl = Implementation.ICU; else if (value.equalsIgnoreCase("jdk")) impl = Implementation.JDK; else throw new RuntimeException("Unknown parameter " + param); } else { throw new RuntimeException("Unknown parameter " + param); } } } {code} > benchmark for collation > ----------------------- > > Key: LUCENE-2181 > URL: https://issues.apache.org/jira/browse/LUCENE-2181 > Project: Lucene - Java > Issue Type: New Feature > Components: contrib/benchmark > Reporter: Robert Muir > Assignee: Robert Muir > Attachments: LUCENE-2181.patch, LUCENE-2181.patch, LUCENE-2181.patch, > LUCENE-2181.patch, LUCENE-2181.patch, > top.100k.words.de.en.fr.uk.wikipedia.2009-11.tar.bz2 > > > Steven Rowe attached a contrib/benchmark-based benchmark for collation (both > jdk and icu) under LUCENE-2084, along with some instructions to run it... > I think it would be a nice if we could turn this into a committable patch and > add it to benchmark. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org