On Sun, Mar 7, 2010 at 12:02 AM, Robert Muir (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/LUCENE-2277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12842337#action_12842337 > ] > > Robert Muir commented on LUCENE-2277: > ------------------------------------- > > Simon you could also say the bug was adding a List to itself... either way it > was wrong. > > I liked the way Frank describes it because if someone else hit this bug, then > they will > recognize the exception message in CHANGES. True! Nevermind!
simon > > >> QueryNodeImpl throws ConcurrentModificationException on add(List<QueryNode>) >> ---------------------------------------------------------------------------- >> >> Key: LUCENE-2277 >> URL: https://issues.apache.org/jira/browse/LUCENE-2277 >> Project: Lucene - Java >> Issue Type: Bug >> Components: contrib/* >> Affects Versions: 3.0 >> Environment: all >> Reporter: Frank Wesemann >> Assignee: Robert Muir >> Priority: Critical >> Fix For: 3.1 >> >> Attachments: addChildren.patch, LUCENE-2277.patch >> >> >> on adding a List of children to a QueryNodeImplemention a >> ConcurrentModificationException is thrown. >> This is due to the fact that QueryNodeImpl instead of iteration over the >> supplied list, iterates over its internal clauses List. >> Patch: >> Index: QueryNodeImpl.java >> =================================================================== >> --- QueryNodeImpl.java (revision 911642) >> +++ QueryNodeImpl.java (working copy) >> @@ -74,7 +74,7 @@ >> >> .getLocalizedMessage(QueryParserMessages.NODE_ACTION_NOT_SUPPORTED)); >> } >> >> - for (QueryNode child : getChildren()) { >> + for (QueryNode child : children) { >> add(child); >> } >> > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-dev-h...@lucene.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org
