[
https://issues.apache.org/jira/browse/LUCENE-2318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845097#action_12845097
]
Shai Erera commented on LUCENE-2318:
------------------------------------
Patch looks good.
I see that you've documented TEST_VERSION_CURRENT in LuceneTestCase(J4) as:
/** Use this constant when creating Analyzers. */. It's used already for
creating IndexWriterConfig,and I assume it will be used for other components as
we'll introduce it in them (LUCENE-2305). So perhaps generalize the jdoc?
It bothered me for a long time that I cannot run some tests from eclipse
because of this 'tempDir'. I'm glad you fixed it !
> Add System.getProperty("tempDir") as final static to LuceneTestCase(J4)
> -----------------------------------------------------------------------
>
> Key: LUCENE-2318
> URL: https://issues.apache.org/jira/browse/LUCENE-2318
> Project: Lucene - Java
> Issue Type: Test
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 3.1
>
> Attachments: LUCENE-2318.patch, LUCENE-2318.patch
>
>
> Almost every test calls System.getProperty("tempDir") and some of them check
> the return value for null. In other cases the test simply fails from within
> eclipse.
> We should add this to LuceneTestCase(J4) as a static final constant. For
> enabling tests run in eclipse, we can add a fallback to ".", if the Sysprop
> is not defined.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
