[
https://issues.apache.org/jira/browse/LUCENE-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845939#action_12845939
]
Chris Male commented on LUCENE-2310:
------------------------------------
{quote}
So overall we agree on the changes that need to be made. BTW, when you
deprecate a method, you usually change it to call the new API or change it to
use the new data structures or whatever. So we need to think how to impl
getFields such that if one calls remove, numFields or use the iterator on an
interleving manner, his code doesn't break ... I don't think it should be hard
but it might be a good idea to even write such (deprecated) unit test
{quote}
I'm not sure we have to change getFields. We can just deprecate it, and point
people to the new methods. I think it'd be more effort than its worth to
create a List impl that calls the new methods. Was that what you were
implying? I do agree its worth writing a test to ensure all old functionality
can be done via the new methods somehow.
> Reduce Fieldable, AbstractField and Field complexity
> ----------------------------------------------------
>
> Key: LUCENE-2310
> URL: https://issues.apache.org/jira/browse/LUCENE-2310
> Project: Lucene - Java
> Issue Type: Sub-task
> Components: Index
> Reporter: Chris Male
> Attachments: LUCENE-2310-Deprecate-AbstractField.patch,
> LUCENE-2310-Deprecate-AbstractField.patch,
> LUCENE-2310-Deprecate-AbstractField.patch
>
>
> In order to move field type like functionality into its own class, we really
> need to try to tackle the hierarchy of Fieldable, AbstractField and Field.
> Currently AbstractField depends on Field, and does not provide much more
> functionality that storing fields, most of which are being moved over to
> FieldType. Therefore it seems ideal to try to deprecate AbstractField (and
> possible Fieldable), moving much of the functionality into Field and
> FieldType.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
