[ https://issues.apache.org/jira/browse/LUCENE-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847906#action_12847906 ]
Paul Elschot edited comment on LUCENE-2337 at 3/21/10 10:14 AM: ---------------------------------------------------------------- The patch updates the javadocs for the move from skipTo() to advance(). It also renames the public method ScorerDocQueue.topSkipToAndAdjustElsePop to top AdvanceAndAdjustElsePop. Although this is a public API change, I don't think it is worthwhile to use deprecation for this, because the method is really Lucene internal. There are also some older things changed: the remark that skipTo() is used is removed (all scorers meanwhile have implemented skipTo() and have moved to advance()), and some commented code lines have are removed. was (Author: paul.elsc...@xs4all.nl): The patch updates the javadocs for the move from skipTo() to advance(). It also renames the public method ScorerDocQueue.topSkipToAndAdjustElsePop to top AdvanceAndAdjustElsePop. Although this is a public API change, I don't think it is worthwhile to use deprecation for this, because the method is really Lucene internal. There are also some leftovers: the remark that skipTo() is used is removed (all scorers meanwhile have implemented skipTo() and have moved to advance()), and some commented code lines have are removed. > DisjunctionSumScorer and ScorerDocQueue javadocs one method name out of date > after move from skipTo() to advance() > ------------------------------------------------------------------------------------------------------------------ > > Key: LUCENE-2337 > URL: https://issues.apache.org/jira/browse/LUCENE-2337 > Project: Lucene - Java > Issue Type: Improvement > Components: Javadocs, Search > Reporter: Paul Elschot > Priority: Trivial > Fix For: 3.1 > > Attachments: LUCENE-2337.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org