[
https://issues.apache.org/jira/browse/LUCENE-2339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848634#action_12848634
]
Earwin Burrfoot commented on LUCENE-2339:
-----------------------------------------
bq. So unless LUCENE-1482 springs back to life again, what do you suggest we
do? Suppressing the exceptions seems wrong to me.
bq. But can we change it to throw the first exception it encounters?
That's exactly what most of lucene is doing when closing something. If you
can't log, you either suppress, or mask the previous exception.
Let's mask it? That way the user may get the wrong exception, but he's not
getting a situation when something failed but looks okay on the surface.
bq. I love CloseSafely! We do that in a number of places and should simply call
it, instead.
I did this for readers in my reopen patch, except new utility method does
decRef.
bq. I also prefer Arrays.asList to be explicit
ok :/
> Allow Directory.copy() to accept a collection of file names to be copied
> ------------------------------------------------------------------------
>
> Key: LUCENE-2339
> URL: https://issues.apache.org/jira/browse/LUCENE-2339
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Earwin Burrfoot
> Assignee: Michael McCandless
> Attachments: LUCENE-2339.patch, LUCENE-2339.patch, LUCENE-2339.patch
>
>
> Par example, I want to copy files pertaining to a certain commit, and not
> everything there is in a Directory.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: java-dev-h...@lucene.apache.org
