I turned this into a unit test... but I don't see it never
returning... the test passes.
How did you create your empty reader?
Patch:
Index: src/test/org/apache/lucene/search/TestMatchAllDocsQuery.java
===================================================================
--- src/test/org/apache/lucene/search/TestMatchAllDocsQuery.java
(revision
916939)
+++ src/test/org/apache/lucene/search/TestMatchAllDocsQuery.java
(working copy)
@@ -27,6 +27,8 @@
import org.apache.lucene.index.IndexReader;
import org.apache.lucene.queryParser.QueryParser;
import org.apache.lucene.store.RAMDirectory;
+import org.apache.lucene.store.Directory;
+import org.apache.lucene.store.MockRAMDirectory;
import org.apache.lucene.util.LuceneTestCase;
@@ -115,6 +117,21 @@
dir.close();
}
+ public void testNeverReturns() throws Exception {
+ Directory dir = new MockRAMDirectory();
+ IndexWriter w = new IndexWriter(dir, new
StandardAnalyzer(TEST_VERSION_CURRENT),
IndexWriter.MaxFieldLength.UNLIMITED);
+ IndexReader r = w.getReader();
+ w.close();
+
+ assertEquals(0, r.numDocs()); // empty index
+ IndexSearcher s = new IndexSearcher(r);
+ TopDocsCollector collector = TopScoreDocCollector.create(0, true);
+ s.search(new MatchAllDocsQuery(), collector); // never returns
+ s.close();
+ r.close();
+ dir.close();
+ }
+
public void testEquals() {
Query q1 = new MatchAllDocsQuery();
Query q2 = new MatchAllDocsQuery();
Mike
On Fri, Feb 26, 2010 at 4:54 PM, Justin <[email protected]> wrote:
> Is this a bug in Lucene Java as of tr...@915399?
>
> int numDocs = reader.numDocs(); // = 0 (empty index)
> TopDocsCollector collector = TopScoreDocCollector.create(numDocs,
> true);
> searcher.search(new MatchAllDocsQuery(), collector); // never
> returns
>
> // Searcher
> public void search(Query query, Collector collector)
> throws IOException {
> search(createWeight(query), null, collector); // never returns
> }
>
> // extends IndexSearcher
> public void search(Weight weight, Filter filter, final Collector
> collector) throws IOException {
> boolean topScorer = (filter == null) true : false;
> Scorer scorer = weight.scorer(reader, true, topScorer);
> if (scorer != null && topScorer) {
> scorer.score(collector); // never returns
>
> // Scorer
> public void score(Collector collector) throws IOException {
> collector.setScorer(this);
> int doc;
> while ((doc = nextDoc()) != NO_MORE_DOCS) { // doc = 0 (infinite)
> collector.collect(doc);
> }
> }
>
>
> Thanks for any feedback,
> Justin
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
