On Tue, Mar 6, 2012 at 9:46 AM, Uwe Schindler <u...@thetaphi.de> wrote: > Hi, > > The recommended way to get an atomic reader from a composite reader is to use > SlowCompositeReaderWrapper.wrap(reader). MultiFields is now purely internal. > I think it's only public because the codecs package may need it, otherwise it > should be pkg-private.
Oh! I'll rework the patch again, then. I might include some commentary in MultiFields at all. > > ----- > Uwe Schindler > H.-H.-Meier-Allee 63, D-28213 Bremen > http://www.thetaphi.de > eMail: u...@thetaphi.de > > >> -----Original Message----- >> From: Benson Margulies [mailto:bimargul...@gmail.com] >> Sent: Tuesday, March 06, 2012 3:40 PM >> To: java-user@lucene.apache.org >> Subject: Re: A little more CHANGES.txt help on terms(), please >> >> On Tue, Mar 6, 2012 at 9:34 AM, Uwe Schindler <u...@thetaphi.de> wrote: >> > Hi, >> > >> > MultiFields should only be used (as it is slow) if you exactly know >> > what you are doing and what the consequences are. There is a change in >> > Lucene 4.0, so you can no longer terms and postings from a top-level >> > (composite) reader. More info is also here: http://goo.gl/lMKTM >> >> Uwe, >> >> The 4.0 change is how I got here in the first place. Some code we have here >> dumped all the terms using the old IndexReader.terms(), so I was working on >> figuring out how to replace it. For my purposes, which are a dev tool, I >> think >> that MultiFields will be fine. >> >> --benson >> >> >> > >> > Uwe >> > >> > ----- >> > Uwe Schindler >> > H.-H.-Meier-Allee 63, D-28213 Bremen >> > http://www.thetaphi.de >> > eMail: u...@thetaphi.de >> > >> > >> >> -----Original Message----- >> >> From: Benson Margulies [mailto:bimargul...@gmail.com] >> >> Sent: Tuesday, March 06, 2012 3:15 PM >> >> To: java-user@lucene.apache.org >> >> Subject: Re: A little more CHANGES.txt help on terms(), please >> >> >> >> On Tue, Mar 6, 2012 at 8:56 AM, Uwe Schindler <u...@thetaphi.de> wrote: >> >> > AtomicReader.fields() >> >> >> >> I went and read up AtomicReader in CHANGES.txt. Should I call >> >> SegmentReader.getReader(IOContext)? >> >> >> >> I just posted a patch to CHANGES.txt to clarify before I read your >> >> email, shall I improve it to use this instead of >> >> >> >> MultiFields.getFields(indexReader).iterator(); >> >> >> >> which I came up with by fishing around for myself? >> >> >> >> > >> >> > ----- >> >> > Uwe Schindler >> >> > H.-H.-Meier-Allee 63, D-28213 Bremen http://www.thetaphi.de >> >> > eMail: u...@thetaphi.de >> >> > >> >> > >> >> >> -----Original Message----- >> >> >> From: Benson Margulies [mailto:bimargul...@gmail.com] >> >> >> Sent: Tuesday, March 06, 2012 2:50 PM >> >> >> To: java-user@lucene.apache.org >> >> >> Subject: A little more CHANGES.txt help on terms(), please >> >> >> >> >> >> Under "LUCENE-1458, LUCENE-2111: Flexible Indexing", CHANGES.txt >> >> >> appears to be missing one critical hint. If you have existing code >> >> >> that called IndexReader.terms(), where do you start to get a >> >> >> FieldsEnum? >> >> >> >> >> >> --------------------------------------------------------------------- >> >> >> To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org >> >> >> For additional commands, e-mail: java-user-h...@lucene.apache.org >> >> > >> >> > >> >> > --------------------------------------------------------------------- >> >> > To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org >> >> > For additional commands, e-mail: java-user-h...@lucene.apache.org >> >> > >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org >> >> For additional commands, e-mail: java-user-h...@lucene.apache.org >> > >> > >> > --------------------------------------------------------------------- >> > To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org >> > For additional commands, e-mail: java-user-h...@lucene.apache.org >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org >> For additional commands, e-mail: java-user-h...@lucene.apache.org > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org > For additional commands, e-mail: java-user-h...@lucene.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: java-user-unsubscr...@lucene.apache.org For additional commands, e-mail: java-user-h...@lucene.apache.org
