On 07-11-2012 6:08 AM, Jonathan Gibbons wrote:
On 11/05/2012 08:06 AM, jayashree viswanathan wrote:
Hi Jon ,

Can you please review the changeset for the bug 7198272 ?

The Changeset and example page are available in the below link .

http://cr.openjdk.java.net/~jviswana/7198272/

Thanks a lot !

Regards,
Jayashree V


Jayashree,

javadoc is currently specified to generate HTML 4.01 output. I don't see the ROLE, ARIA-LABEL and ARIA-LABELLED-BY attribute being defined there. Is this a new attribute for HTML 5 or did I mis it somewhere in the 4.01 spec? If this is new for HTML 5, we need to think about how best to handle having javadoc generate HTML 5 docs -- for example, what about frames?

Also, in reading through your code in HtmlWriter, we are moving away from building long strings in favor of building HtmlTree nodes. So, it would be better to follow that paradigm here as well.

-- Jon


Hi Jon ,

http://www.w3.org/TR/wai-aria/appendices

Please read through "10.1.6. HTML 4.01 plus WAI-ARIA DTD" . The question on if we would like to move upto HTML 5, XHTML now can be a separate discussion as always with each offering some advantages Vs the other and javadoc as a tool can move upto one of these with changes to be made for them based on need.

Though I believe this need not be an impediment to move to WAI-ARIA standard as mentioned in the page itself to move to this upcoming standard .

I agree with your point on HtmlTree nodes and can add the ARIA attributes to the node, rather than constructing a string and I can make the changes and pass on a fresh webrev soon .

Thanks and Regards,
Jayashree V





Reply via email to