Looks good.
-Sundar
On 05/12/18, 7:38 PM, Hannes Wallnöfer wrote:
Thanks for the review.
I added a @serialField tag to the existing serializedForm test. Also, I removed
the private Checker#isArrayType method which isn’t used anymore.
New webrev:
http://cr.openjdk.java.net/~hannesw/8214571/webrev.01/
Hannes
Am 04.12.2018 um 16:59 schrieb Jonathan Gibbons<[email protected]>:
On 12/4/18 7:53 AM, Hannes Wallnöfer wrote:
Please review:
Bug: https://bugs.openjdk.java.net/browse/JDK-8214571
Webrev: http://cr.openjdk.java.net/~hannesw/8214571/webrev.00/
I changed the handling of array types in reference tags from causing an error
to just generating a link to the element type.
I only updated the existing tests, should I add a test specifically for
@serialField as well?
Thanks,
Hannes
Since the regression was on @serialField, I think we should have a test for
@serialField. Let me know if you want help creating the test.
-- Jon
