I found a few problems with the first webrev. First, the generated documentation didn’t render correctly on some versions of Internet Explorer, because I had left away some markup/css that is not required in current browsers.
Second, I had omitted some *Writers that still outputted the old markup, namely ConstantsSummaryWriter, SerializedFormWriter, AllPackagesIndexWriter and AllClassesIndexWriter. The new webrev below takes care of these issues. New webrev: cr.openjdk.java.net/~hannesw/8223378/webrev.02/ New docs: http://cr.openjdk.java.net/~hannesw/8223378/api.02/ Hannes > Am 31.10.2019 um 15:40 schrieb Hannes Wallnöfer > <[email protected]>: > > Please review: > > JBS: https://bugs.openjdk.java.net/browse/JDK-8223378 > Webrev: http://cr.openjdk.java.net/~hannesw/8223378/webrev.01/ > API docs: http://cr.openjdk.java.net/~hannesw/8223378/api.01/ > > This implements the CSS Flexible Box Layout Module based page structure for > the fixed header. > I added a new PageContent builder class to simplify generation of the new > layout structure across all the writer classes. In the process I also cleaned > up some code a bit (getting rid of unused fields and parameters, removing > obsolete javascript etc). > > Thanks, > Hannes
