Looks good to me.

Note that a blank line crept in TestHelpOption.java, that you may way to remove before pushing the change.

  * @summary  Make sure that --help, -helpfile and -nohelp options work 
correctly.
- * @author   jamieh
+
  * @library ../../lib

-- Jon


On 12/5/19 1:53 PM, Pavel Rappo wrote:
Hello,

Please review the following change for 
https://bugs.openjdk.java.net/browse/JDK-8235435:

     http://cr.openjdk.java.net/~prappo/8235435/webrev.00/author.patch

This change removes occurrences of @author tags throughout the source files and 
tests in Javadoc. It cleanly removes all the tags from the sources, but not 
from all the tests. It has been identified that some of the tests use @author 
tags, meaningfully as part of their scenarios. More effort is required to find 
out which, if any, tags can safely be removed from those tests.

Given the sheer number (270) of changed files and the nature of the change, I 
decided not to create a proper webrev. Instead, the link contains only a single 
diff file which can be reviewed either as text or in your IDEs.

Thanks,
-Pavel

Reply via email to