Thanks for the reviews. I was quite unsure about @bug tag rules, so thanks for the clarification and link.
I uploaded a new webrev with no @bug additions, otherwise no changes from previous webrev. http://cr.openjdk.java.net/~hannesw/8232438/webrev.01/ Hannes > Am 20.02.2020 um 18:49 schrieb Jonathan Gibbons <[email protected]>: > > > On 2/20/20 7:14 AM, Pavel Rappo wrote: >> Hi Hannes, >> >> What is the background of this "?is-external=true" feature? How was it used >> in >> the first place? Is there anything I can read on that? > > My recollection/impression is that this may have been related to the frames > feature > and to support for updating the window title. If you want to follow up, I > recommend > getting an older copy of the source and look for occurrences of the string, > particularly > in .js files. > > >> >> I'm surprised to see the tests' @bug tags are updated to include this bug >> number. >> >> I thought that an @bug tag needs to be updated when the test has been >> meaningfully >> changed. In other words, when the relation between the test and the bug is >> stronger than mere "updated because otherwise fails". > Agreed, >> >> I appreciate that the semantics of @bug might depend on the area, still: >> >> >> https://openjdk.java.net/jtreg/faq.html#when-should-i-update-the-bug-entry-in-a-test-description > I think opinions have differed over time, and there is room for a range of > opinion. > I think the best way to look at this is to ask, if I want to select and run > the tests related > to a specific bug fix, should I include this test. That is what the `@bug` > tag and the > corresponding `-bug` option are for. > >> >> -Pavel >> >>> On 20 Feb 2020, at 13:09, Hannes Wallnöfer <[email protected]> >>> wrote: >>> >>> Please review: >>> >>> JBS: https://bugs.openjdk.java.net/browse/JDK-8232438 >>> Webrev: http://cr.openjdk.java.net/~hannesw/8232438/webrev.00/ >>> >>> The is-external=true query was the only use of query functionality in >>> DocLink, so I removed support for query strings in DocLink. The rest of the >>> patch consists of removing the query string from test fixtures. >>> >>> Thanks, >>> Hannes
