Hi Jon, The proposed patch does fix the issue in question. That said, I noticed one more visual difference between the current L&F and that of before JDK-8240916: the font size of search result items.
Long story short, there's one more class name we forgot to change, "resultItem". I'm not sure though how to update the proposed test to cover for that case too. Otherwise, looks good. -Pavel > On 19 Mar 2020, at 21:08, Jonathan Gibbons <[email protected]> > wrote: > > Please review a very simple fix for the reported regression. The fix is just > to update the search.js file with the hyphenated class names. > > Since there is no compile-time check between the contents of a JavaScript > file and the contents of a stylesheet file, I've updated TestSearch.java to > check that any CSS class names referenced in the JavaScript file also appear > in the stylesheet file. > > Note: there is another old-style stylesheet files with camelCase names in the > test directory, that could be updated at some point. > open/test/langtools/jdk/javadoc/doclet/testOptions/custom-stylesheet.css > This file exists to help test options, and the content does not appear to be > important. Updating it can be done separately. > > -- Jon > > JBS: https://bugs.openjdk.java.net/browse/JDK-8241292 > Webrev: http://cr.openjdk.java.net/~jjg/8241292/webrev.00/index.html > >
