+1
On 6/2/20 9:34 AM, Hannes Wallnoefer wrote:
I have uploaded a new Webrev that preserves the trailing slash, and only
removes it when rendering the link.
http://cr.openjdk.java.net/~hannesw/8164408/webrev.01/
I also replaced the getReferencedClassName method in class CommentHelper with a
new getReferencedModuleName that makes use of the new module reference syntax
as that method is only used to create links to external modules.
Hannes
Am 02.06.2020 um 17:14 schrieb Jonathan Gibbons <[email protected]>:
On 6/2/20 7:13 AM, Hannes Wallnoefer wrote:
That’s correct, the toString() representation and default link label will be
different from the actual string in the doc comment. The rationale is that the
trailing slash is there just to disambiguate the link as a module reference,
and the slash is not part of the actual module name.
If it is important to preserve the link signature as-is we can keep it in the
signature. We’ll have to check for it later on when checking for external
module references, but that is not a problem.
Hannes
Hannes,
The tree .toString() should be an accurate/exact rendition of the input. It's a
"syntax" tree representing the input. It should not be desugared/pre-rendered
into what we might want for the output.
The form of any generated text should be determined when generating the text,
-- Jon
