Thanks! > Am 04.06.2020 um 16:51 schrieb Jonathan Gibbons <[email protected]>: > > +1 > > I'll comment that the edits are inconsistent with using `{ }` around > single-statements after `if (...)`. Note sure if that was deliberate or not.
I know. I usually try to be consistent with the style of the method I’m adding to, which in this case unfortunately varies within a single class. Hannes > Test: yay for Text Blocks. > > -- Jon > > On 6/4/20 7:19 AM, Hannes Wallnoefer wrote: >> Please review: >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8246429 >> Webrev: http://cr.openjdk.java.net/~hannesw/8246429/webrev.00/ >> >> I originally fixed this as part of 8198705: Javadoc search needs a fix to >> handle duplicate package names in different modules, but it is a distinct >> issue so I filed a separate bug for it. >> >> The fix adds an additional final step to element comparisons, which is to >> compare the name of the modules containing the elements. So far the final >> step in most comparators was to compare the fully qualified name of the >> elements. >> >> Hannes
