On Wed, 23 Sep 2020 03:34:29 GMT, Vicente Romero <[email protected]> wrote:
>> Co-authored-by: Vicente Romero <[email protected]> >> Co-authored-by: Harold Seigel <[email protected]> >> Co-authored-by: Jonathan Gibbons <[email protected]> >> Co-authored-by: Brian Goetz <[email protected]> >> Co-authored-by: Maurizio Cimadamore <[email protected]> >> Co-authored-by: Joe Darcy <[email protected]> >> Co-authored-by: Chris Hegarty <[email protected]> >> Co-authored-by: Jan Lahoda <[email protected]> > > Vicente Romero has updated the pull request incrementally with three > additional commits since the last revision: > > - Merge pull request #1 from ChrisHegarty/record-serial-tests > > Remove preview args from JDK tests > - Remove preview args from ObjectMethodsTest > - Remove preview args from record serialization tests Marked as reviewed by chegar (Reviewer). test/langtools/tools/javac/records/LocalStaticDeclarations.java line 33: > 31: * jdk.compiler/com.sun.tools.javac.util > 32: * @build combo.ComboTestHelper > 33: * @compile LocalStaticDeclarations.java This, and other, explicit at compile tags could be elided, no? The test source file will be implicitly compiled by the at run tag. I believe that the explicit at compile tag was added original so that the enable preview and source version options could be passed to javac - neither of which are needed any more. ------------- PR: https://git.openjdk.java.net/jdk/pull/290
