On Tue, 3 Nov 2020 10:24:55 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains three commits: >> >> - Merge master >> - introduce getHeader >> - JDK-8248320: Provide a unique accessible name for <nav role="navigation"> > > Looks good, Jon! > > In order to clean up, the following could and should probably be removed: > - `HtmlStyle.bottomNav` > - Instances of `bottom-nav` in stylesheet.css > - `*_BOTTOM_NAVBAR` constants in MarkerComments Thanks; I'll take care of that cleanup. -- Jon On 11/3/20 2:25 AM, Hannes Wallnoefer wrote: > > *@hns* approved this pull request. > > Looks good, Jon! > > In order to clean up, the following could and should probably be removed: > > * |HtmlStyle.bottomNav| > * Instances of |bottom-nav| in stylesheet.css > * |*_BOTTOM_NAVBAR| constants in MarkerComments > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://urldefense.com/v3/__https://github.com/openjdk/jdk/pull/710*pullrequestreview-522358876__;Iw!!GqivPVa7Brio!OZ9iGgSl8q-Drk_U444pXFzZHIhWqvKUkfERyZg-zXFchd9lsdYUk8LZnQ4eBPohDTKmQA$>, > > or unsubscribe > <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AOUXBRXQQRGLYLFS2OADNUDSN7LALANCNFSM4STZDN6Q__;!!GqivPVa7Brio!OZ9iGgSl8q-Drk_U444pXFzZHIhWqvKUkfERyZg-zXFchd9lsdYUk8LZnQ4eBPqhVzAmtw$>. > ------------- PR: https://git.openjdk.java.net/jdk/pull/710
