On Fri, 13 Nov 2020 01:10:06 GMT, Yoshiki Sato <[email protected]> wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/DocLint.java line
>> 348:
>>
>>> 346: String argVersion = arg.substring(arg.indexOf(":") +
>>> 1);
>>> 347: if (argVersion == null || !argVersion.equals("html5"))
>>> {
>>> 348: throw new IllegalArgumentException(argVersion);
>>
>> These lines are only used when invoked from javac/javadoc etc, so it would
>> be reasonable to delete them entirely, provided those tools never try and
>> use this option.
>
> These lines are likely to be used as long as the "--doclint-format html5"
> option is permitted. For example, this option is still used in the
> make/common/JavaCompilation.gmk.
1. we can update make/common/JavaCompilation.gmk
2. the option in javac/javadoc should be converted to a no-op so that it does
not get passed down to doclint
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/resources/doclint.properties
>> line 32:
>>
>>> 30: dc.attr.not.supported.html5 = attribute not supported in HTML5: {0}
>>> 31: dc.attr.obsolete = attribute obsolete: {0}
>>> 32: dc.attr.obsolete.use.css = attribute obsolete, use CSS instead: {0}
>>
>> Is this still required?
>
> Do you mean ".html5" would be better to be removed?
> If so, yes. I just left it because the message would be friendly if it still
> say "attribute not supported in HTML5".
Sorry, the comment is incorrectly focussed (and annoyingly cryptic: my
apologies).
I think I was referring to `dc.attr.obsolete.use.css`
-------------
PR: https://git.openjdk.java.net/jdk/pull/893
