On Tue, 12 Jan 2021 12:34:44 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:

>> liach has updated the pull request with a new target base due to a merge or 
>> a rebase.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java
>  line 331:
> 
>> 329:     }
>> 330: 
>> 331:     public boolean isRecursivelyAnnotated(TypeMirror e) {
> 
> I'm not sure this needs to be a new public  method in `Utils` since it is 
> only used by `AbstractExcecutableMemberWriter`. It also seems to do more than 
> is necessary for that use case (array, wildcard).

Agreed. Moved this to a helper method like `addParameters` in 
`AbstractExcecutableMemberWriter`. Also changed test so the tests for 
`Generic2`'s doc group together.

-------------

PR: https://git.openjdk.java.net/jdk/pull/1997

Reply via email to