On Wed, 5 May 2021 13:55:10 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:

>> This changes reference parsing in `DocCommentParser` to normalize whitespace 
>> in signatures to a large extent. In particular, multiple whitespace 
>> characters are coalesced into a single space character, and whitespace after 
>> opening parentheses and angle brackets are suppressed.
>
> Hannes Wallnöfer has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   JDK-8250766: Add missing null check and update copyright year

Marked as reviewed by prappo (Reviewer).

src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/CommentHelper.java
 line 471:

> 469:     @SuppressWarnings("fallthrough")
> 470:     private static String normalizeSignature(String sig) {
> 471:         if (sig == null

Consider removing this null check since we've agreed that 
ReferenceTree.getSignature() does not return null.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3754

Reply via email to