On Thu, 6 May 2021 13:47:13 GMT, Hannes Wallnöfer <[email protected]> wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review comments
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java
> line 2149:
>
>> 2147: for (TypeElement c : classes) {
>> 2148: list.addAll(getItems0(c, all, filter, clazz));
>> 2149: recursiveGetItems(list, c, all, filter, clazz);
>
> It seems you are adding these items twice, directly in the first line of the
> loop and then again in the recursive invocation. (I think this was carried
> over from the prior implementation.)
fixed
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/Utils.java
> line 2166:
>
>> 2164: return e.getEnclosedElements().stream()
>> 2165: .filter(e_ -> select.test(e_) && (all ||
>> shouldDocument(e_)))
>> 2166: .map(ee -> clazz.cast(ee))
>
> Could be written as method reference.
done
-------------
PR: https://git.openjdk.java.net/jdk/pull/3821
