On Thu, 6 May 2021 14:54:11 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8263507: More suggested code cleanup > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/AllClassesIndexWriter.java > line 125: > >> 123: .addTab(contents.exceptions.toString(), e -> >> utils.isException((TypeElement)e)) >> 124: .addTab(contents.errors.toString(), e -> >> utils.isError((TypeElement)e)) >> 125: .addTab(contents.annotationTypes.toString(), >> utils::isAnnotationType); > > Maybe the `*Tab` methods could be overloaded to accept `Content` ? Maybe > later cleanup? > What does `.toString()` do in the malformed case of providing an `HtmlTree` > ... should there be a method on `Content`? Maybe later cleanup? The `*Tab` methods could and should be converted to accept `Content`. I didn't want to pack too many unrelated changes into this issue so I have filed a separate one for it: https://bugs.openjdk.java.net/browse/JDK-8266651 ------------- PR: https://git.openjdk.java.net/jdk/pull/3413
