On Tue, 18 May 2021 16:22:56 GMT, liach <github.com+7806504+li...@openjdk.org> wrote:
> For this change, in fact, you can pretty much discard all previous change; > the current commit is not related to the previous commit contents, as the way > of approach and the test both got rewritten. Yet, it is preferable to have preceding commits. GitHub and Webrev links refer to commits by their hashes. If you spare these commits, links will break. Broken links make it harder to follow the history. > For squashing and pushing, I thought it was a requirement for JDK pull > requests to be merged; maybe the openjdk bot prompted me so before since I > cannot find the reference on > [http://openjdk.java.net/contribute](http://openjdk.java.net/contribute/). > Would you mind enlightening me on how to keep commit histories while adhering > to the bot's requirements? The page you refer to, http://openjdk.java.net/contribute/, is somewhat outdated. While it is being updated, may I refer you to https://wiki.openjdk.java.net/display/SKARA instead? In particular, please read https://wiki.openjdk.java.net/display/SKARA/FAQ. As a PR author the only thing you need to be concerned with, from a VCS perspective, is that your PR has no conflicts with the master. If that's the case, all the rebasing and squashing will be done for you automatically. Your best course of action is to respond to feedback normally by adding commits to your PR branch, not by overwriting them. ------------- PR: https://git.openjdk.java.net/jdk/pull/4066
