On Thu, 3 Jun 2021 16:59:22 GMT, Jonathan Gibbons <j...@openjdk.org> wrote:
>> Removal of ugly old code in `SerializedFormBuilder.java`. Luckily there
>> already is a clean overloaded method in the associated writer that we can
>> use, so this is mostly a removal of code that is no longer used.
>>
>> I also enhanced the test to cover more cases such as primitive arrays and
>> linked references.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlSerialFieldWriter.java
> line 123:
>
>> 121: } else {
>> 122: Content fieldContent = writer.getLink(new HtmlLinkInfo(
>> 123: configuration, HtmlLinkInfo.Kind.SERIAL_MEMBER,
>> fieldType));
>
> Just curious, is SERIAL_MEMBER still required?
`SERIAL_MEMBER` is still used in the remaining `addMemberHeader` method below.
On a deeper level it doesn't seem to be required, as there isn't any link
formatting rule associated with it, i.e. it uses the default link format. But
this is probably true for several of the 35 `HtmlLinkInfo.Kind` constants we
currently have. If we wanted to reduce the number of `HtmlLinkInfo.Kind` enum
constants we should file a separate JBS issue.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4284
