On Wed, 28 Jul 2021 15:31:11 GMT, liach <github.com+7806504+li...@openjdk.org>
wrote:
>> Pavel Rappo has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Change AnnotatedText<T> to StyledText
>>
>> Renames the class, removes its generic parameter, and changes the related
>> terminology from "annotate" to "style".
>> - Restructure ...toolkit.taglets.snippet.** packages
>>
>> This commit moves the contents of the
>> jdk.javadoc.internal.doclets.toolkit.taglets.snippet.{action,parser,text}
>> packages into the jdk.javadoc.internal.doclets.toolkit.taglets.snippet
>> package.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Action.java
> line 37:
>
>> 35: * deletion without notice.</b>
>> 36: */
>> 37: // FIXME: uncomment /* sealed */ when minimum boot version >= 17
>
> Do we still have to wait? Currently `java.lang.reflect.Executable` and
> `java.lang.constant.ClassDesc` are already sealed. I wonder if uncommenting
> here is fine.
Unlike java.base, which the types you mentioned belong to, jdk.javadoc is built
using boot JDK. If the JDK being built is of version N, then boot JDK is of
version N-1 or N-2. Typically, the minimum version of boot JDK in the mainline
is bumped in a few weeks time after GA has been released.
If I uncommented those FIXMEs now, I would see this:
Compiling 241 files for BUILD_jdk.javadoc.interim
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Action.java:38:
error: sealed classes are a preview feature and are disabled by default.
public sealed interface Action permits AddStyle, Bookmark, Replace {
^
(use --enable-preview to enable sealed classes)
src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/taglets/snippet/Action.java:38:
error: '{' expected
public sealed interface Action permits AddStyle, Bookmark, Replace {
^
2 errors
Currently in the mainline, java.base is built by JDK 18 and jdk.javadoc is
built by JDK 16. The latter is because JDK 17 has not been released yet.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4795
