On Tue, 24 Aug 2021 21:56:05 GMT, Jonathan Gibbons <[email protected]> wrote:
>> Generally impressive piece of work.
>
>> @jonathan-gibbons, do we need to mention the semantic change to
>> `com.sun.source.doctree.AttributeTree` in the release notes? Before this PR,
>> `AttributeTree` used to only represent HTML attributes. After this PR has
>> been integrated, that interface will also represent attributes of the
>> standard doclet tags. (Currently, the only such tag is `{@snippet}`.)
>
> It doesn't seem worth a release note ... we're just using the tree in more
> places ... but it wouldn't be wrong to create one ... after all, I guess we
> did have to change doclint to accommodate the new usage.
> @jonathan-gibbons, I'm currently cleaning up this PR of unrelated changes.
> What would you say if I ask you to extract this change of yours into a
> separate cleanup PR while I delete it from this PR?
>
> [openjdk/jdk-sandbox@405c89c#diff-e7650e24c581f8df74f8d2bc24110c15c22fd32308f690fba0349c7170f320dfR495-R499](https://github.com/openjdk/jdk-sandbox/commit/405c89c35076e73daf7b38d5a20ae83075fb8ae1#diff-e7650e24c581f8df74f8d2bc24110c15c22fd32308f690fba0349c7170f320dfR495-R499)
>
> Adding `tagletpath.parameters` and changing `tagletpath.description` has
> value, but I think you would agree that it's unrelated to snippets.
>
> Separately, when extracting the diff note that that change is a bit
> inconsistent: while you changed the resource value to `The path for custom
> taglets`, the option doc comment still refers to `The path to Taglets`:
> https://github.com/openjdk/jdk-sandbox/blob/405c89c35076e73daf7b38d5a20ae83075fb8ae1/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/BaseOptions.java#L268
So you're just suggesting that I should handle the parts related to tagletPath,
right? If so, OK.
-------------
PR: https://git.openjdk.java.net/jdk/pull/4795
