Please review a moderately simple update to convert JavadocTester to just use 
NIO, instead of a mix of File and NIO.

The original code used java.io.File. At some point (JDK 9-ish) new code was 
added that used NIO, resulting in a mix. This change converts the old code to 
use NIO as well.

This is mostly internal, with two changes that affect tests.

1. The `protected` field `outputDir` is changed from a `File` to a `Path`.   
Some tests use `outputDir` directly, typically to convert it to a `Path`.
2. The `copyDir` method had a strange spec.  Partly, it used "target" to 
describe the directory being copied, but worse, it copied the entire source 
directory INTO the destination directory, as compared to copying the contents.  
The method was just used in a single test, so I've changed the spec of the 
method and the use in the test.  This cleaned up a "TODO" as well, to use 
`Files.walkFileTree` for the copy.

-------------

Commit messages:
 - JDK-8274172: Convert JavadocTester to use NIO

Changes: https://git.openjdk.java.net/jdk/pull/5644/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5644&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8274172
  Stats: 166 lines in 7 files changed: 40 ins; 35 del; 91 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5644.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5644/head:pull/5644

PR: https://git.openjdk.java.net/jdk/pull/5644

Reply via email to